Re: [PATCH 7/9] hook: allow out-of-repo 'git hook' invocations

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Jul 16, 2021, 08:33 UTC
Message-ID: <87tukuy7vc.fsf@evledraar.gmail.com>
In-Reply-To: <20210715232603.3415111-8-emilyshaffer@google.com>

On Thu, Jul 15 2021, Emily Shaffer wrote:

Show 8 quoted lines

> Since hooks can now be supplied via the config, and a config can be
> present without a gitdir via the global and system configs, we can start
> to allow 'git hook run' to occur without a gitdir. This enables us to do
> things like run sendemail-validate hooks when running 'git send-email'
> from a nongit directory.
>
> It still doesn't make sense to look for hooks in the hookdir in nongit
> repos, though, as there is no hookdir.

Hrm, I haven't tested but re the discussion we had about RUN_SETUP_GENTLY on my re-rolled base topic is this really just a regression in my changes there?

I.e. I assumed we could do RUN_SETUP for the bug-for-bug compatibility step, but send-email runs out of repo hooks and we just didn't have tests for it, or am I missing something?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.