Re: [PATCH v2 04/30] gc: use hook library for pre-auto-gc hook

From: Emily Shaffer <emilyshaffer@google.com>
Date: Jun 14, 2021, 23:57 UTC
Message-ID: <YMfs4Zr4Q22W5dnB@google.com>
In-Reply-To: <patch-04.30-da2763192ae-20210614T101920Z-avarab@gmail.com>

On Mon, Jun 14, 2021 at 12:32:53PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 5 quoted lines

> 
> 
> Using the hook.h library instead of the run-command.h library to run
> pre-auto-gc means that those hooks can be set up in config files, as
> well as in the hookdir. pre-auto-gc is called only from builtin/gc.c.

I think all the commit messages in "convert x to hook library" commits I wrote extol the virtues of config-based hooks. Since that's not part of your reroll, I expect we should change the commit messages too.

 - Emily

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.