Re: [PATCH v5 0/4] unpack_trees_options: free messages when done

From: Jeff King <peff@peff.net>
Date: May 21, 2018, 21:38 UTC
Message-ID: <20180521213804.GA16285@sigill.intra.peff.net>
In-Reply-To: <cover.1526913784.git.martin.agren@gmail.com>

On Mon, May 21, 2018 at 04:54:24PM +0200, Martin Ågren wrote:

Show 7 quoted lines

> That is, I've replaced the `string_list_appendf()`-patch with Junio's
> `argv_push*()`-patch, then squashed Junio's "redoing the 4/4"-patch into
> patch 4/4 -- with the exception of keeping the `memset(opts->msgs, ...)`
> which I suspect was mistakenly dropped.
> 
> Again, thanks for all the helpful comments and patches pointing me in
> the right direction.

I like it. Thanks for seeing it through. That was a lot of back-and-forth for a small cleanup, but I hope we've established a pattern that can be used elsewhere.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.