Re: [PATCH 5/8] rebase: introduce the --recreate-merges option

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 15, 2018, 16:50 UTC
Message-ID: <nycvar.QRO.7.76.6.1802151748160.35@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
In-Reply-To: <87a7wazx8k.fsf@javad.com>

Hi,

On Thu, 15 Feb 2018, Sergey Organov wrote:

Show 21 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> [...]
> 
> >> > I'd not argue this way myself. If there are out-of-git-tree non-human
> >> > users that accept and tweak todo _generated_ by current "git rebase -p"
> >> > _command_, I also vote for a new option.
> >> >
> >> 
> >> To be fair, I have not seen anything that actually reads the todo list
> >> and tweaks it in such a manner. The closest example is the git garden
> >> shears script, which simply replaces the todo list.
> >> 
> >> It's certainly *possible* that such a script would exist though,
> >
> > We actually know of such scripts.
> 
> Please consider to explain this in the description of the change. I
> believe readers deserve an explanation of why you decided to invent new
> option instead of fixing the old one, even if it were only a suspicion,
> more so if it is confidence.

I considered.

And since even the absence of this use case would *still* not be a convincing case against keeping --preserve-merges backwards-compatible, I will not mention it.

Just saying that --preserve-merges is not changed, in order to keep backwards-compatibility, is plenty enough.

It probably already convinced the Git maintainer, who is very careful about backwards-compatibility, and rightfully so.

Ciao, Johannes