From: Jeff King <peff@peff.net>
Date: Mon, 21 May 2018 21:38:04 GMT
Subject: Re: [PATCH v5 0/4] unpack_trees_options: free messages when done
Message-ID: <20180521213804.GA16285@sigill.intra.peff.net>
In-Reply-To: <cover.1526913784.git.martin.agren@gmail.com>

On Mon, May 21, 2018 at 04:54:24PM +0200, Martin Ågren wrote:

> That is, I've replaced the `string_list_appendf()`-patch with Junio's
> `argv_push*()`-patch, then squashed Junio's "redoing the 4/4"-patch into
> patch 4/4 -- with the exception of keeping the `memset(opts->msgs, ...)`
> which I suspect was mistakenly dropped.
> 
> Again, thanks for all the helpful comments and patches pointing me in
> the right direction.

I like it. Thanks for seeing it through. That was a lot of
back-and-forth for a small cleanup, but I hope we've established a
pattern that can be used elsewhere.

-Peff