Re: [PATCH 1/8] sequencer: introduce new commands to reset the revision
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Jan 18, 2018, 16:25 UTC
- Message-ID
- <CA+P7+xozcQD2xuys6mh8MsfcYZ_nb2c9yxhDxkc7FTN2SfoofQ@mail.gmail.com>
- In-Reply-To
- <8a91bf2184a3da4c0d5a13ba184813068e51f5c8.1516225925.git.johannes.schindelin@gmx.de>
On Thu, Jan 18, 2018 at 7:35 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
Show 10 quoted lines
> This commit implements the commands to label, and to reset to, given > revisions. The syntax is: > > label <name> > reset <name> > > As a convenience shortcut, also to improve readability of the generated > todo list, a third command is introduced: bud. It simply resets to the > "onto" revision, i.e. the commit onto which we currently rebase. >
The code looks good, but I'm a little wary of adding bud which hard-codes a specific label. I suppose it does grant a bit of readability to the resulting script... ? It doesn't seem that important compared to use using "reset onto"? At least when documenting this it should be made clear that the "onto" label is special.
Thanks, Jake.