Re: [PATCH v6 00/15] rebase -i: offer to recreate commit topology

From: Sergey Organov <sorganov@gmail.com>
Date: Apr 10, 2018, 14:52 UTC
Message-ID: <87tvsj6rn2.fsf@javad.com>
In-Reply-To: <cover.1523362469.git.johannes.schindelin@gmx.de>

Hi Johannes,

Johannes Schindelin <johannes.schindelin@gmx.de> writes:

> Once upon a time, I dreamt of an interactive rebase that would not
> flatten branch structure, but instead recreate the commit topology
> faithfully.

[...]

> Think of --rebase-merges as "--preserve-merges done right".

Both option names seem to miss the primary point of the mode of operation that you've formulated in the first sentence. I suggest to rather call the new option in accordance to your description, say, --no-flatten, --keep-topology, or --preserve-shape.

Besides, this way the option name will only specify one thing: _what_ it is about, leaving out the _how_ part, that could vary and could then be specified as option value or as another companion option(s), that is usually considered to be an indication of a good design.

-- Sergey

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.