Re: [PATCH v2 2/4] rebase -i: Handle "combination of <n> commits" with GETTEXT_POISON
- From
Stefan Beller <sbeller@google.com>
- Date
- Apr 20, 2018, 21:16 UTC
- Message-ID
- <CAGZ79kZM3Q-HnPAqMUZM_NtfCumsWBtwrFT2HPkU_d95iJdzOQ@mail.gmail.com>
- In-Reply-To
- <6fe8b38c7097c826f17e5f45e39ffbc35a529849.1524258351.git.johannes.schindelin@gmx.de>
On Fri, Apr 20, 2018 at 2:07 PM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
Show 8 quoted lines
> We previously relied on the localized versions of > > # This is a combination of <N> commits > > (which we write into the commit messages during fixup/squash chains) > to contain <N> as ASCII. > > Thisis not true in general, and certainly not in GETTEXT_POISON, as
This is
Apart from this typo, this patch looks good.