Re: [PATCH v3 0/4] rebase -i: avoid stale "# This is a combination of" in commit messages
- From
Stefan Beller <sbeller@google.com>
- Date
- Apr 23, 2018, 18:11 UTC
- Message-ID
- <CAGZ79kbK7j0njrZ8-d_Da6+XyH_RVRhBu=hcpzr7EFsOCSFJVQ@mail.gmail.com>
- In-Reply-To
- <cover.1524296064.git.johannes.schindelin@gmx.de>
On Sat, Apr 21, 2018 at 12:34 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:
Show 16 quoted lines
> Eric Sunshine pointed out that I had such a commit message in > https://public-inbox.org/git/CAPig+cRrS0_nYJJY=O6cboV630sNQHPV5QGrQdD8MW-sYzNFGQ@mail.gmail.com/ > and I went on a hunt to figure out how the heck this happened. > > Turns out that if there is a fixup/squash chain where the *last* command > fails with merge conflicts, and we either --skip ahead or resolve the > conflict to a clean tree and then --continue, our code does not do a > final cleanup. > > Contrary to my initial gut feeling, this bug was not introduced by my > rewrite in C of the core parts of rebase -i, but it looks to me as if > that bug was with us for a very long time (at least the --skip part). > > The developer (read: user of rebase -i) in me says that we would want to > fast-track this, but the author of rebase -i in me says that we should > be cautious and cook this in `next` for a while.
I looked through the patches again and think this series is good to go.
Thanks, Stefan