[PATCH v4 02/12] sequencer: make rearrange_squash() a bit more obvious
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 23, 2018, 12:36 UTC
- Message-ID
- <a7e01df062d64a2b89c99a4de4a772cfb0c84017.1519389319.git.johannes.schindelin@gmx.de>
- In-Reply-To
- <cover.1519389319.git.johannes.schindelin@gmx.de>
There are some commands that have to be skipped from rearranging by virtue of not handling any commits.
However, the logic was not quite obvious: it skipped commands based on their position in the enum todo_command.
Instead, let's make it explicit that we skip all commands that do not handle any commit. With one exception: the `drop` command, because it, well, drops the commit and is therefore not eligible to rearranging.
Note: this is a bit academic at the moment because the only time we call `rearrange_squash()` is directly after generating the todo list, when we have nothing but `pick` commands anyway.
However, the upcoming `merge` command *will* want to be handled by that function, and it *can* handle commits.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- sequencer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sequencer.c b/sequencer.c index 5aa3dc3c95c..cfa01d3bdd2 100644 --- a/sequencer.c +++ b/sequencer.c @@ -3412,7 +3412,7 @@ int rearrange_squash(void) struct subject2item_entry *entry; next[i] = tail[i] = -1; - if (item->command >= TODO_EXEC) { + if (!item->commit || item->command == TODO_DROP) { subjects[i] = NULL; continue; }
-- 2.16.1.windows.4