Re: [PATCH 1/8] sequencer: introduce new commands to resettherevision

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Jan 19, 2018, 18:55 UTC
Message-ID: <229b332d-56b8-0183-f57b-b0db0c62f781@talktalk.net>
In-Reply-To: <d069a3c7-198e-81d2-0f35-f934e110c991@philandanna.no-ip.org>

On 19/01/18 12:24, Phillip Wood wrote:

Show 14 quoted lines

> 
> On 18/01/18 15:35, Johannes Schindelin wrote:
>>
>> Internally, the `label <name>` command creates the ref
>> `refs/rewritten/<name>`. This makes it possible to work with the labeled
>> revisions interactively, or in a scripted fashion (e.g. via the todo
>> list command `exec`).
> 
> If a user has two work trees and runs a rebase in each with the same
> label name, they'll clobber each other. I'd suggest storing them under
> refs/rewritten/<branch-name or detached HEAD SHA> instead. If the user
> tries to rebase a second worktree with the same detached HEAD as an
> existing rebase then refuse to start.
>

Ah this isn't a concern after all as patch 5 makes refs/rewritten local to the worktree. Perhaps you could move that part of patch 5 here or add a note to the commit message that it will become worktree local later in the series

Best Wishes

Phillip