Re: [PATCH 1/8] sequencer: introduce new commands to reset the revision
- From
Jacob Keller <jacob.keller@gmail.com>
- Date
- Jan 18, 2018, 21:21 UTC
- Message-ID
- <CA+P7+xo096LyacgFM3kLMHovXT3sWsf_m9AB7oENREZ7TfWa9Q@mail.gmail.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.1801182212210.31@ZVAVAG-6OXH6DA.rhebcr.pbec.zvpebfbsg.pbz>
On Thu, Jan 18, 2018 at 1:13 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 33 quoted lines
> Hi Jake, > > On Thu, 18 Jan 2018, Jacob Keller wrote: > >> On Thu, Jan 18, 2018 at 7:35 AM, Johannes Schindelin >> <johannes.schindelin@gmx.de> wrote: >> > This commit implements the commands to label, and to reset to, given >> > revisions. The syntax is: >> > >> > label <name> >> > reset <name> >> > >> > As a convenience shortcut, also to improve readability of the generated >> > todo list, a third command is introduced: bud. It simply resets to the >> > "onto" revision, i.e. the commit onto which we currently rebase. >> > >> >> The code looks good, but I'm a little wary of adding bud which >> hard-codes a specific label. I suppose it does grant a bit of >> readability to the resulting script... ? It doesn't seem that >> important compared to use using "reset onto"? At least when >> documenting this it should be made clear that the "onto" label is >> special. > > Indeed, `bud` helped me more in the earlier times of the Git garden shears > when I had to *introduce* branch structure into the long list of Git for > Windows' patches. > > If there are no voices in favor of `bud` other than mine, I will remove > support for it in the next iteration. > > Ciao, > Dscho
After I saw more examples, I don't mind it. I do think it's not strictly necessary, but it seemed to help me with the readability. My only main concern is that it's limited to a special label.
Thanks, Jake