git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by:

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 19, 2020, 22:17 UTC
Message-ID
<xmqqy2k1dfoh.fsf@gitster.c.googlers.com>
In-Reply-To
<20201019220214.GB49623@nand.local>
Taylor Blau <me@ttaylorr.com> writes:
Show 5 quoted lines
> I think that the 3-patch series that Junio was talking about in [1] is
> actually this one [2].
> ...
> [1]: https://lore.kernel.org/git/xmqqmu0it6ls.fsf@gitster.c.googlers.com/
> [2]: https://lore.kernel.org/git/20201018194912.2716372-1-gitster@pobox.com/
True.

I actually think it is a bad idea to add ":" after every mention of "Signed-off-by"; it only looks clarifying because we use a boring and generic word "line" to refer to where that three-word token appears.

We can say "a 'Signed-off-by' trailer" and it becomes plenty clear that we are not talking about any random line in the log message, and we do not need ":" everywhere, I suspect.

Thanks.
Previous: Taylor BlauNext: Bradley M. Kuhn
Message 20 of 35 in “Clarify and expand description of --signoff”
  1. 0/1 Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  2. 1/1 Documentation: Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  3. Jeff KingOct 16, 2020
  4. Theodore Y. Ts'oOct 18, 2020
  5. Philippe BlainOct 16, 2020
  6. Junio C HamanoOct 16, 2020
  7. Jeff KingOct 16, 2020
  8. Junio C HamanoOct 16, 2020
  9. Junio C HamanoOct 16, 2020
  10. Jeff KingOct 16, 2020
  11. Bradley M. KuhnOct 17, 2020
  12. Junio C HamanoOct 18, 2020
  13. Theodore Y. Ts'oOct 19, 2020
  14. Junio C HamanoOct 19, 2020
  15. 0/3 clarify and expand description of --signoff & related fixesBradley M. Kuhn, Oct 19, 2020
  16. 1/3 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 19, 2020
  17. 3/3 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 19, 2020
  18. 2/3 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 19, 2020
  19. Taylor BlauOct 19, 2020
  20. Junio C HamanoOct 19, 2020
  21. 0/4 clarify meaning of --signoff & related doc improvements in describing Signed-off-byBradley M. Kuhn, Oct 20, 2020
  22. 1/4 doc: preparatory clean-up of description on the sign-off optionBradley M. Kuhn, Oct 20, 2020
  23. 2/4 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 20, 2020
  24. Bradley M. KuhnOct 20, 2020
  25. Taylor BlauOct 20, 2020
  26. 3/4 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 20, 2020
  27. 4/4 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 20, 2020
  28. Junio C HamanoOct 20, 2020
  29. Bradley M. KuhnOct 20, 2020
  30. Taylor BlauOct 20, 2020
  31. Bradley M. KuhnOct 20, 2020
  32. Taylor BlauOct 20, 2020
  33. Junio C HamanoOct 20, 2020
  34. Bradley M. KuhnOct 20, 2020
  35. Taylor BlauOct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.