Re: [PATCH 1/1] Documentation: Clarify and expand description of --signoff
- From
Jeff King <peff@peff.net>
- Date
- Oct 16, 2020, 00:46 UTC
- Message-ID
- <20201016004603.GC2932796@coredump.intra.peff.net>
- In-Reply-To
- <20201015215933.96425-2-bkuhn@sfconservancy.org>
On Thu, Oct 15, 2020 at 02:59:33PM -0700, Bradley M. Kuhn wrote:
Show 10 quoted lines
> Building on past documentation improvements in Commit > b2c150d3aa (Expand documentation describing --signoff, 2016-01-05), > further clarify that any project using Git may and often does set its > own policy. > > However, leave intact reference to the Linux DCO, which Git also > uses. It is reasonable for Git to advocate for its own Signed-off-by > methodology in its documentation, as long as the documentation > remains respectful that YMMV and other projects may well have very > different contributor representations tied to Signed-off-by.
I think this is worth doing, and doesn't really change the intent of what we were trying to do with b2c150d3aa. It just says it a bit more clearly, IMHO.
Except for one minor nit below, the patch looks good to me. Unsurprisingly, since as you mentioned we discussed it off-list already. :)
To be clear, it's...
Signed-off-by: Jeff King <peff@peff.net>
as far as any words I contributed.
As far as your patch formatting, submission, etc, it looks OK. I probably would've kept "clarify" in the title as lowercase. I'd also usually not do a separate cover letter for a single-patch series (and instead put anything not meant for the commit message after the "---" line). But that's mostly a matter of taste (a lot of people do separate cover letters).
Show 7 quoted lines
> diff --git a/Documentation/merge-options.txt b/Documentation/merge-options.txt > index 80d4831662..c9df9cc0f4 100644 > --- a/Documentation/merge-options.txt > +++ b/Documentation/merge-options.txt > [...] > + leadership of the project to which you're contributing to understand > + how the signoffs are used in that project.
Extra leading space on this final line.
-Peff
PS Since this is your first patch submission, welcome to the Git project. ;)