git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 2/4] Documentation: clarify and expand description of --signoff

From
Bradley M. Kuhn <bkuhn@sfconservancy.org>
Date
Oct 20, 2020, 21:44 UTC
Message-ID
<20201020214431.GA1398231@ebb.org>
In-Reply-To
<418d15c53268f947e11dac2f22d1f8c3c8c60997.1603155607.git.bkuhn@sfconservancy.org>
Junio,
Junio wrote in the sub-thread about [PATCH v3 4/4]:
>> It seems the patches [1-3/4] are identical to what has been queued
>> in 'seen', which is a good sign.

One change I made in v3 patchset was to add Peff's Signed-off-by, as it is *not* there in commit 04c2b9ebd0 in seen:

I wrote in [PATCH v3 2/4]:
> Signed-off-by: Jeff King <peff@peff.net>

… given that Peff made edits to this before it was posted, I think we want to be sure Peff's Signed-off-by is included. It just seems like the "right thing" to get the Signed-off-by trailers 100% correct on a commit that changes the description of Signed-off-by. 😆

I wrote in [PATCH v3 2/4]:
> Reviewed-by: Taylor Blau <me@ttaylorr.com>

I doubt Taylor cares whether this Reviewed-by trailer makes it in, but I did add that too based on Taylor providing it earlier in the discussion of this patch. ☺ -- Bradley M. Kuhn - he/him Policy Fellow & Hacker-in-Residence at Software Freedom Conservancy ======================================================================== Become a Conservancy Supporter today: https://sfconservancy.org/supporter

Previous: Bradley M. KuhnNext: Taylor Blau
Message 24 of 35 in “Clarify and expand description of --signoff”
  1. 0/1 Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  2. 1/1 Documentation: Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  3. Jeff KingOct 16, 2020
  4. Theodore Y. Ts'oOct 18, 2020
  5. Philippe BlainOct 16, 2020
  6. Junio C HamanoOct 16, 2020
  7. Jeff KingOct 16, 2020
  8. Junio C HamanoOct 16, 2020
  9. Junio C HamanoOct 16, 2020
  10. Jeff KingOct 16, 2020
  11. Bradley M. KuhnOct 17, 2020
  12. Junio C HamanoOct 18, 2020
  13. Theodore Y. Ts'oOct 19, 2020
  14. Junio C HamanoOct 19, 2020
  15. 0/3 clarify and expand description of --signoff & related fixesBradley M. Kuhn, Oct 19, 2020
  16. 1/3 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 19, 2020
  17. 3/3 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 19, 2020
  18. 2/3 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 19, 2020
  19. Taylor BlauOct 19, 2020
  20. Junio C HamanoOct 19, 2020
  21. 0/4 clarify meaning of --signoff & related doc improvements in describing Signed-off-byBradley M. Kuhn, Oct 20, 2020
  22. 1/4 doc: preparatory clean-up of description on the sign-off optionBradley M. Kuhn, Oct 20, 2020
  23. 2/4 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 20, 2020
  24. Bradley M. KuhnOct 20, 2020
  25. Taylor BlauOct 20, 2020
  26. 3/4 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 20, 2020
  27. 4/4 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 20, 2020
  28. Junio C HamanoOct 20, 2020
  29. Bradley M. KuhnOct 20, 2020
  30. Taylor BlauOct 20, 2020
  31. Bradley M. KuhnOct 20, 2020
  32. Taylor BlauOct 20, 2020
  33. Junio C HamanoOct 20, 2020
  34. Bradley M. KuhnOct 20, 2020
  35. Taylor BlauOct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.