Re: [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by:
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 20, 2020, 02:31 UTC
- Message-ID
- <20201020023138.GA54484@nand.local>
- In-Reply-To
- <xmqqy2k1dfoh.fsf@gitster.c.googlers.com>
On Mon, Oct 19, 2020 at 03:17:02PM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> Taylor Blau <me@ttaylorr.com> writes: > > > I think that the 3-patch series that Junio was talking about in [1] is > > actually this one [2]. > > ... > > [1]: https://lore.kernel.org/git/xmqqmu0it6ls.fsf@gitster.c.googlers.com/ > > [2]: https://lore.kernel.org/git/20201018194912.2716372-1-gitster@pobox.com/ > > True. > > I actually think it is a bad idea to add ":" after every mention of > "Signed-off-by"; it only looks clarifying because we use a boring > and generic word "line" to refer to where that three-word token > appears. > > We can say "a 'Signed-off-by' trailer" and it becomes plenty clear > that we are not talking about any random line in the log message, > and we do not need ":" everywhere, I suspect.
Mm. I may be in the minority that I think having ":" after "Signed-off-by" is helpful, but I'm happy to go whichever way others find most clear.
> Thanks.
Thanks, Taylor