git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] Clarify and expand description of --signoff

From
Jeff King <peff@peff.net>
Date
Oct 16, 2020, 20:11 UTC
Message-ID
<20201016201119.GA3356073@coredump.intra.peff.net>
In-Reply-To
<xmqqh7quaqwb.fsf@gitster.c.googlers.com>
On Fri, Oct 16, 2020 at 12:53:56PM -0700, Junio C Hamano wrote:
Show 8 quoted lines
> > Jeff King <peff@peff.net> writes:
> >
> >> What should we change there? We could perhaps bring up signoffs earlier
> >> or more prominently. Or tie it in to the git-commit docs by saying
> >> explicitly: these are _our_ project rules for signoffs.
> 
> Let's tie this loose end.  How about squashing in something like
> this?

Thanks for writing this up. I agree it makes the text much better (not only in emphasizing the point we've been discussing, but also in general clarity).

You said "squashing", but I'd suggest keeping it as its own patch on top of Bradley's.

-Peff
Previous: Junio C HamanoNext: Bradley M. Kuhn
Message 10 of 35 in “Clarify and expand description of --signoff”
  1. 0/1 Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  2. 1/1 Documentation: Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  3. Jeff KingOct 16, 2020
  4. Theodore Y. Ts'oOct 18, 2020
  5. Philippe BlainOct 16, 2020
  6. Junio C HamanoOct 16, 2020
  7. Jeff KingOct 16, 2020
  8. Junio C HamanoOct 16, 2020
  9. Junio C HamanoOct 16, 2020
  10. Jeff KingOct 16, 2020
  11. Bradley M. KuhnOct 17, 2020
  12. Junio C HamanoOct 18, 2020
  13. Theodore Y. Ts'oOct 19, 2020
  14. Junio C HamanoOct 19, 2020
  15. 0/3 clarify and expand description of --signoff & related fixesBradley M. Kuhn, Oct 19, 2020
  16. 1/3 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 19, 2020
  17. 3/3 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 19, 2020
  18. 2/3 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 19, 2020
  19. Taylor BlauOct 19, 2020
  20. Junio C HamanoOct 19, 2020
  21. 0/4 clarify meaning of --signoff & related doc improvements in describing Signed-off-byBradley M. Kuhn, Oct 20, 2020
  22. 1/4 doc: preparatory clean-up of description on the sign-off optionBradley M. Kuhn, Oct 20, 2020
  23. 2/4 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 20, 2020
  24. Bradley M. KuhnOct 20, 2020
  25. Taylor BlauOct 20, 2020
  26. 3/4 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 20, 2020
  27. 4/4 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 20, 2020
  28. Junio C HamanoOct 20, 2020
  29. Bradley M. KuhnOct 20, 2020
  30. Taylor BlauOct 20, 2020
  31. Bradley M. KuhnOct 20, 2020
  32. Taylor BlauOct 20, 2020
  33. Junio C HamanoOct 20, 2020
  34. Bradley M. KuhnOct 20, 2020
  35. Taylor BlauOct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.