Re: [PATCH 0/1] Clarify and expand description of --signoff
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 18, 2020, 19:08 UTC
- Message-ID
- <xmqqwnzn73og.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20201016201119.GA3356073@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> On Fri, Oct 16, 2020 at 12:53:56PM -0700, Junio C Hamano wrote: > >> > Jeff King <peff@peff.net> writes: >> > >> >> What should we change there? We could perhaps bring up signoffs earlier >> >> or more prominently. Or tie it in to the git-commit docs by saying >> >> explicitly: these are _our_ project rules for signoffs. >> >> Let's tie this loose end. How about squashing in something like >> this? > > Thanks for writing this up. I agree it makes the text much better (not > only in emphasizing the point we've been discussing, but also in general > clarity). > > You said "squashing", but I'd suggest keeping it as its own patch on top > of Bradley's.
OK, let's do so.
I recall I read that Bradley's patch needs a bit of word/grammo polishing?
Thanks.