git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 0/4] clarify meaning of --signoff & related doc improvements in describing Signed-off-by

From
Bradley M. Kuhn <bkuhn@sfconservancy.org>
Date
Oct 20, 2020, 01:03 UTC
Message-ID
<cover.1603155607.git.bkuhn@sfconservancy.org>
In-Reply-To
<xmqqy2k1dfoh.fsf@gitster.c.googlers.com>
[ Note that there were competing v2's of this patch series, one from me and
  one from Junio.  Sorry about that; I had missed Junio's from Sunday. ]

I believe this patch series now addresses all the issues raised in the discussion.

  * [1/4] is unchanged from Junio's v2 and is the preparatory cleanup.
  * [2/4] remains unchanged textually since I originally posted it and Pfeff
    signed off.
  * [3/4] is unchanged from Junio's v2 and is his clarification for what
     Git's --signoff means.
     
  * [4/4] is a rework of a patch from *my* v2.  It takes into account Junio's
    comments about preferring the word "trailer" and leaving off the ':'
    whenever possible when discussing Signed-off-by.
For reference:
        v1: https://lore.kernel.org/git/20201015215933.96425-1-bkuhn@sfconservancy.org/
Junio's v2: https://lore.kernel.org/git/20201018194912.2716372-1-gitster@pobox.com/
     my v2: https://lore.kernel.org/git/cover.1603142543.git.bkuhn@sfconservancy.org/
Bradley M. Kuhn (2):
  Documentation: clarify and expand description of --signoff
  Documentation: stylistically normalize references to Signed-off-by:
Junio C Hamano (2):
  doc: preparatory clean-up of description on the sign-off option
  SubmittingPatches: clarify DCO is our --signoff rule
 Documentation/MyFirstContribution.txt |  2 +-
 Documentation/SubmittingPatches       | 35 +++++++++++++++------------
 Documentation/config/format.txt       |  2 +-
 Documentation/git-am.txt              |  2 +-
 Documentation/git-cherry-pick.txt     |  2 +-
 Documentation/git-commit.txt          | 10 ++------
 Documentation/git-format-patch.txt    |  2 +-
 Documentation/git-rebase.txt          |  2 +-
 Documentation/git-revert.txt          |  2 +-
 Documentation/git-send-email.txt      |  4 +--
 Documentation/git-svn.txt             |  4 +--
 Documentation/githooks.txt            |  2 +-
 Documentation/merge-options.txt       | 11 +--------
 Documentation/signoff-option.txt      | 18 ++++++++++++++
 builtin/am.c                          |  2 +-
 builtin/commit.c                      |  2 +-
 builtin/log.c                         |  2 +-
 builtin/merge.c                       |  2 +-
 builtin/pull.c                        |  2 +-
 builtin/rebase.c                      |  2 +-
 builtin/revert.c                      |  2 +-
 commit.c                              |  2 +-
 22 files changed, 60 insertions(+), 54 deletions(-)
 create mode 100644 Documentation/signoff-option.txt
-- 
Bradley M. Kuhn - he/him
Policy Fellow & Hacker-in-Residence at Software Freedom Conservancy
========================================================================
Become a Conservancy Supporter today: https://sfconservancy.org/supporter
Previous: Junio C HamanoNext: Bradley M. Kuhn
Message 21 of 35 in “Clarify and expand description of --signoff”
  1. 0/1 Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  2. 1/1 Documentation: Clarify and expand description of --signoffBradley M. Kuhn, Oct 15, 2020
  3. Jeff KingOct 16, 2020
  4. Theodore Y. Ts'oOct 18, 2020
  5. Philippe BlainOct 16, 2020
  6. Junio C HamanoOct 16, 2020
  7. Jeff KingOct 16, 2020
  8. Junio C HamanoOct 16, 2020
  9. Junio C HamanoOct 16, 2020
  10. Jeff KingOct 16, 2020
  11. Bradley M. KuhnOct 17, 2020
  12. Junio C HamanoOct 18, 2020
  13. Theodore Y. Ts'oOct 19, 2020
  14. Junio C HamanoOct 19, 2020
  15. 0/3 clarify and expand description of --signoff & related fixesBradley M. Kuhn, Oct 19, 2020
  16. 1/3 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 19, 2020
  17. 3/3 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 19, 2020
  18. 2/3 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 19, 2020
  19. Taylor BlauOct 19, 2020
  20. Junio C HamanoOct 19, 2020
  21. 0/4 clarify meaning of --signoff & related doc improvements in describing Signed-off-byBradley M. Kuhn, Oct 20, 2020
  22. 1/4 doc: preparatory clean-up of description on the sign-off optionBradley M. Kuhn, Oct 20, 2020
  23. 2/4 Documentation: clarify and expand description of --signoffBradley M. Kuhn, Oct 20, 2020
  24. Bradley M. KuhnOct 20, 2020
  25. Taylor BlauOct 20, 2020
  26. 3/4 SubmittingPatches: clarify DCO is our --signoff ruleBradley M. Kuhn, Oct 20, 2020
  27. 4/4 Documentation: stylistically normalize references to Signed-off-by:Bradley M. Kuhn, Oct 20, 2020
  28. Junio C HamanoOct 20, 2020
  29. Bradley M. KuhnOct 20, 2020
  30. Taylor BlauOct 20, 2020
  31. Bradley M. KuhnOct 20, 2020
  32. Taylor BlauOct 20, 2020
  33. Junio C HamanoOct 20, 2020
  34. Bradley M. KuhnOct 20, 2020
  35. Taylor BlauOct 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.