Re: [PATCH v3 4/4] Documentation: stylistically normalize references to Signed-off-by:
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 20, 2020, 18:52 UTC
- Message-ID
- <xmqq8sc0d91d.fsf@gitster.c.googlers.com>
- In-Reply-To
- <448b9d464eafdb0ee8faa8cd41ee08f844e27701.1603155607.git.bkuhn@sfconservancy.org>
"Bradley M. Kuhn" <bkuhn@sfconservancy.org> writes:
Show 7 quoted lines
> Ted reported an old typo in the git-commit.txt and merge-options.txt. > Namely, the phrase "Signed-off-by line" was used without either a > definite nor indefinite article. > > Upon examination, it seems that the documentation (including items in > Documentation/, but also option help strings) have been quite > inconsistent on usage when referring to `Signed-off-by`.
Thanks. This must have been a lot of proofreading ;-)
It seems the patches [1-3/4] are identical to what has been queued in 'seen', which is a good sign. There was a reversion of a typofix in the log message of one of them, though.
Show 25 quoted lines
> diff --git a/Documentation/git-send-email.txt b/Documentation/git-send-email.txt > index 0a69810147..b7bbbeadef 100644 > --- a/Documentation/git-send-email.txt > +++ b/Documentation/git-send-email.txt > @@ -313,7 +313,7 @@ Automating > the value of `sendemail.identity`. > > --[no-]signed-off-by-cc:: > - If this is set, add emails found in Signed-off-by: or Cc: lines to the > + If this is set, add emails found in the `Signed-off-by` trailer or Cc: lines to the > cc list. Default is the value of `sendemail.signedoffbycc` configuration > value; if that is unspecified, default to --signed-off-by-cc. > > @@ -340,7 +340,7 @@ Automating > except for self (use 'self' for that). > - 'bodycc' will avoid including anyone mentioned in Cc lines in the > patch body (commit message) except for self (use 'self' for that). > -- 'sob' will avoid including anyone mentioned in Signed-off-by lines except > > +- 'sob' will avoid including anyone mentioned in the Signed-off-by trailers except > for self (use 'self' for that). > - 'misc-by' will avoid including anyone mentioned in Acked-by, > Reviewed-by, Tested-by and other "-by" lines in the patch body, > > diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
Did you hand edit the second hunk starting at line 340 to git-send-email.txt? I've fixed it up manually, so no need to resend.
Thanks.