From: Junio C Hamano Date: Mon, 19 Oct 2020 22:17:02 GMT Subject: Re: [PATCH v2 2/3] Documentation: stylistically normalize references to Signed-off-by: Message-ID: In-Reply-To: <20201019220214.GB49623@nand.local> Taylor Blau writes: > I think that the 3-patch series that Junio was talking about in [1] is > actually this one [2]. > ... > [1]: https://lore.kernel.org/git/xmqqmu0it6ls.fsf@gitster.c.googlers.com/ > [2]: https://lore.kernel.org/git/20201018194912.2716372-1-gitster@pobox.com/ True. I actually think it is a bad idea to add ":" after every mention of "Signed-off-by"; it only looks clarifying because we use a boring and generic word "line" to refer to where that three-word token appears. We can say "a 'Signed-off-by' trailer" and it becomes plenty clear that we are not talking about any random line in the log message, and we do not need ":" everywhere, I suspect. Thanks.