Re: [PATCH 1/1] Documentation: Clarify and expand description of --signoff

From: Theodore Y. Ts'o <tytso@mit.edu>
Date: Oct 18, 2020, 15:13 UTC
Message-ID: <20201018151315.GJ181507@mit.edu>
In-Reply-To: <20201015215933.96425-2-bkuhn@sfconservancy.org>

On Thu, Oct 15, 2020 at 02:59:33PM -0700, Bradley M. Kuhn wrote:

Show 8 quoted lines

> diff --git a/Documentation/git-commit.txt b/Documentation/git-commit.txt
> index a3baea32ae..93bbae4ded 100644
> --- a/Documentation/git-commit.txt
> +++ b/Documentation/git-commit.txt
> @@ -166,11 +166,14 @@ The `-m` option is mutually exclusive with `-c`, `-C`, and `-F`.
>  -s::
>  --signoff::
>  	Add Signed-off-by line by the committer at the end of the commit

While we're editing this, how about changing the above to read:

	Add a Signed-off-by line...

to fix a grammer nit. We do use a similar formulation later the git merge-options man page:

>  With --no-signoff do not add a Signed-off-by line.

Show 8 quoted lines

> diff --git a/Documentation/merge-options.txt b/Documentation/merge-options.txt
> index 80d4831662..c9df9cc0f4 100644
> --- a/Documentation/merge-options.txt
> +++ b/Documentation/merge-options.txt
> @@ -80,11 +80,14 @@ actual commits being merged.
>  --signoff::
>  --no-signoff::
>  	Add Signed-off-by line by the committer at the end of the commit

... and again here.

Thanks!

					- Ted