Re: [PATCH] mktag tests: fix broken "&&" chain

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 7, 2021, 20:43 UTC
Message-ID: <xmqqy2ey7kzx.fsf@gitster.c.googlers.com>
In-Reply-To: <20210307132905.14212-1-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 7 quoted lines

> Remove a stray "xb" I inadvertently introduced in 780aa0a21e0 (tests:
> remove last uses of GIT_TEST_GETTEXT_POISON=false, 2021-02-11). This
> would have been a failed attempt to type "C-x C-b" that snuck into the
> code.
>
> The chainlint check did not catch this one, but I don't know where to
> start patching the wall-of-sed that is chainlint.sed to fix that.

I do not think the chainlint check is designed to deal with helper functions, but I wonder why nobody noticed a runtime failure. Is this an unused/dead codepath?

Show 18 quoted lines

> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  t/t3800-mktag.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh
> index 60a666da595..6275c98523f 100755
> --- a/t/t3800-mktag.sh
> +++ b/t/t3800-mktag.sh
> @@ -17,7 +17,7 @@ check_verify_failure () {
>  		grep '$2' message &&
>  		if test '$3' != '--no-strict'
>  		then
> -			test_must_fail git mktag --no-strict <tag.sig 2>message.no-strict &&xb
> +			test_must_fail git mktag --no-strict <tag.sig 2>message.no-strict &&
>  			grep '$2' message.no-strict
>  		fi
>  	"