[PATCH v4 07/20] mktag tests: don't pipe to stderr needlessly
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Dec 23, 2020, 01:35 UTC
- Message-ID
- <20201223013606.7972-8-avarab@gmail.com>
- In-Reply-To
- <20201209200140.29425-1-avarab@gmail.com>
Remove the piping of stderr to "message" in the valid tag test. This pattern seems to have been copy/pasted from the failure case in 446c6faec6 (New tests and en-passant modifications to mktag., 2006-07-29).
Nothing is piped to "message" here, and in the event of the test failing it only serves to hide the error.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- t/t3800-mktag.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t3800-mktag.sh b/t/t3800-mktag.sh index 9ae1b0bb0a..bbd148618e 100755 --- a/t/t3800-mktag.sh +++ b/t/t3800-mktag.sh @@ -257,7 +257,7 @@ EOF test_expect_success \ 'allow empty tag email' \ - 'git mktag <tag.sig >.git/refs/tags/mytag 2>message' + 'git mktag <tag.sig >.git/refs/tags/mytag' ############################################################ # 16. disallow spaces in tag email @@ -385,7 +385,7 @@ EOF test_expect_success \ 'create valid tag' \ - 'git mktag <tag.sig >.git/refs/tags/mytag 2>message' + 'git mktag <tag.sig >.git/refs/tags/mytag' ############################################################ # 25. check mytag
-- 2.29.2.222.g5d2a92d10f8