Re: [PATCH v2 00/10] make "mktag" use fsck_tag()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 1, 2020, 20:01 UTC
- Message-ID
- <xmqqlfehpa7p.fsf@gitster.c.googlers.com>
- In-Reply-To
- <87zh2xvny6.fsf@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 13 quoted lines
> On Thu, Nov 26 2020, Ævar Arnfjörð Bjarmason wrote: > >> Now a non-RFC. I went for the approach I suggested in >> <87r1ognv4b.fsf@evledraar.gmail.com> of just having fsck_tag() able to >> optionally tell us about its parsed tag/type, thus avoiding any need >> for a custom parser in mktag.c. Hopefully I've addressed the rest of >> the feedback, range-diff below. > > Ping @ Jeff & brian: you said you wanted this in one shape or another, > so mind seeing if the v2 looks good to you?:) > > Junio didn't pick it up for the "What's Cooking" sent out recently, > hopefully some reviewer ACK/NACK will help move it forward. Thanks!
True. I don't want to queue too many topics on 'seen', only to end up with a pile of patches that haven't been reviewed adequately and cannot move forward.