Re: Should you use test_i18ngrep or GIT_TEST_GETTEXT_POISON=false?

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 11, 2021, 21:05 UTC
Message-ID: <xmqqim836v6m.fsf@gitster.c.googlers.com>
In-Reply-To: <87pn2b6eyb.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> What do you think about just removing it? I.e. make setting it a noop?

I have been seeing occasional CI job failures from new tests that forget to use test_i18ngrep. I actually think marking such a grep as "this is looking for a string that is meant for humans" a good way to document the interface and expected end-user interaction, so I am not sure about just removing it.

So after all, test_i18ngrep may make more sense than setting GIT_TEST_GETTEXT_POISON to false. I dunno.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.