Re: [PATCH 0/2] diff tests: un-flaky and post-gettext-poison cleanup

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 13, 2021, 21:42 UTC
Message-ID: <xmqqpmyxkgjb.fsf@gitster.g>
In-Reply-To: <cover-0.2-00000000000-20210413T122645Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

Show 6 quoted lines

> In reply to [1] because they're related post-GETTEXT_POISON cleanup,
> but both apply on top of master.
>
> I had a flaky t4013 test with some local WIP code that I hadn't
> investigated, as it turns out re-running the test was hiding the
> failure. 2/2 fixes that, 1/2 is a minor post-GETTEXT_POISON cleanup.

I feel somewhat offended to see t4013's "auto preparation of the expected output" feature (which of course I invented) as "flakey" ;-) but I agree that was a misfeature. Thanks for taking a look.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.