Re: [PATCH v2 02/10] mktag: use default strbuf_read() hint
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Dec 1, 2020, 20:19 UTC
- Message-ID
- <xmqq5z5lp9d9.fsf@gitster.c.googlers.com>
- In-Reply-To
- <20201126222257.5629-3-avarab@gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
Show 17 quoted lines
> Change the hardcoded hint of 2^12 to 0. The default strbuf hint is > perfectly fine here, and the only reason we were hardcoding it is > because it survived migration from a pre-strbuf fixed-sized buffer. > > See fd17f5b5f77 (Replace all read_fd use with strbuf_read, and get rid > of it., 2007-09-10) for that migration. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > builtin/mktag.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/builtin/mktag.c b/builtin/mktag.c > index 4982d3a93e..ff7ac8e0e5 100644 > --- a/builtin/mktag.c > +++ b/builtin/mktag.c > @@ -161,7 +161,7 @@ int cmd_mktag(int argc, const char **argv, const char *prefix)
In the lines beyond the pre-context there is a comment that mentions <sha1>, but I think it is sensible not to clean it up with this patch, as it will go away with the main "use fsck machinery" step.
Show 7 quoted lines
> if (argc != 1)
> usage("git mktag");
>
> - if (strbuf_read(&buf, 0, 4096) < 0) {
> + if (strbuf_read(&buf, 0, 0) < 0) {
> die_errno("could not read from stdin");
> }