Re: [PATCH 1/2] diff tests: remove redundant case statement

From: Matheus Tavares Bernardino <matheus.bernardino@usp.br>
Date: Apr 13, 2021, 14:18 UTC
Message-ID: <CAHd-oW5nwzg4iiDheMPLe_M19SXO9hPhGeJK8dWfZ-yTKkPVmA@mail.gmail.com>
In-Reply-To: <patch-1.2-35e77153831-20210413T122645Z-avarab@gmail.com>

On Tue, Apr 13, 2021 at 9:31 AM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 16 quoted lines

>
> diff --git a/t/t4013-diff-various.sh b/t/t4013-diff-various.sh
> index 6cca8b84a6b..67f6411aff9 100755
> --- a/t/t4013-diff-various.sh
> +++ b/t/t4013-diff-various.sh
> @@ -220,13 +220,7 @@ do
>                 then
>                         process_diffs "$actual" >actual &&
>                         process_diffs "$expect" >expect &&
> -                       case $cmd in
> -                       *format-patch* | *-stat*)
> -                               test_cmp expect actual;;
> -                       *)
> -                               test_cmp expect actual;;
> -                       esac &&
> -                       rm -f "$actual" actual expect

Was this line removed by accident? It doesn't seem related to the described change. Shouldn't this line be left after...

> +                       test_cmp expect actual

...this one?

Show 6 quoted lines

>                 else
>                         # this is to help developing new tests.
>                         cp "$actual" "$expect"
> --
> 2.31.1.646.g06d606cb9c7
>