Re: [RFC/PATCH 05/12] mktag tests: remove needless SHA-1 hardcoding

From: Jeff King <peff@peff.net>
Date: Nov 26, 2020, 07:49 UTC
Message-ID: <X79eCcmLbgtV1jzJ@coredump.intra.peff.net>
In-Reply-To: <20201126012854.399-6-avarab@gmail.com>

On Thu, Nov 26, 2020 at 02:28:47AM +0100, Ævar Arnfjörð Bjarmason wrote:

Show 7 quoted lines

> But here we're testing for a SHA-length string which contains
> characters outside of the /[0-9a-f]/i set. Let's just do that with a
> ROT13 invocation.
> 
> We could get really unlucky and switch to a future hash function that
> just happens to produce all [0-9] output for this particular input,
> but that's very unlikely.

Maybe s/[0-9a-f]/z/ would be both simpler and more robust?

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.