[PATCH v5 14/23] mktag: use default strbuf_read() hint
- From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
- Date
- Jan 5, 2021, 19:42 UTC
- Message-ID
- <20210105194252.627-15-avarab@gmail.com>
- In-Reply-To
- <20201223013606.7972-1-avarab@gmail.com>
Change the hardcoded hint of 2^12 to 0. The default strbuf hint is perfectly fine here, and the only reason we were hardcoding it is because it survived migration from a pre-strbuf fixed-sized buffer.
See fd17f5b5f77 (Replace all read_fd use with strbuf_read, and get rid of it., 2007-09-10) for that migration.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/mktag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/builtin/mktag.c b/builtin/mktag.c index 4982d3a93ef..ff7ac8e0e5d 100644 --- a/builtin/mktag.c +++ b/builtin/mktag.c @@ -161,7 +161,7 @@ int cmd_mktag(int argc, const char **argv, const char *prefix) if (argc != 1) usage("git mktag"); - if (strbuf_read(&buf, 0, 4096) < 0) { + if (strbuf_read(&buf, 0, 0) < 0) { die_errno("could not read from stdin"); }
-- 2.29.2.222.g5d2a92d10f8