Re: [PATCH v5 05/15] pkt-line: add packet_write_gently_fmt()
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 10, 2016, 18:42 UTC
- Message-ID
- <xmqqvaz84g9y.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <2B2AC073-95AD-42E9-AD3A-23E8E13C66DE@gmail.com>
Lars Schneider <larsxschneider@gmail.com> writes:
Show 8 quoted lines
>>> Similarly, I'd think this could share code with the non-gentle form >>> (which should be able to just call this and die() if returns an error). >>> Though sometimes the va_list transformation makes that awkward. >> >> Yes. > > Peff just posted that he tried the shared code idea but the result > ended up ugly.
OK.