Re: [PATCH v5 02/15] pkt-line: call packet_trace() only if a packet is actually send

From: Lars Schneider <larsxschneider@gmail.com>
Date: Aug 10, 2016, 13:24 UTC
Message-ID: <4111F00D-74A9-449D-BDE9-EE170DA4A403@gmail.com>
In-Reply-To: <20160810131317.a4npld5hf2qk6wiq@sigill.intra.peff.net>

Show 14 quoted lines

> On 10 Aug 2016, at 15:13, Jeff King <peff@peff.net> wrote:
> 
> On Wed, Aug 10, 2016 at 03:03:58PM +0200, larsxschneider@gmail.com wrote:
> 
>> From: Lars Schneider <larsxschneider@gmail.com>
>> 
>> The packet_trace() call is not ideal in format_packet() as we would print
>> a trace when a packet is formatted and (potentially) when the packet is
>> actually send. This was no problem up until now because format_packet()
>> was only used by one function. Fix it by moving the trace call into the
>> function that actually sends the packet.
> 
> It looks like there are two functions: packet_write() and
> packet_buf_write().

I did not call trace in packet_buf_write() because this function does not perform any writes.

> Your patch only touches one of them, and it looks like we would fail to
> trace many packets (e.g., see receive-pack.c:report(), which uses
> packet_buf_write() and then write()s out the result).

I see. But isn't it confusing if packet_buf_write() issues a trace call? If I just call this function then nothing happens at all. Shouldn't the trace call be made in receive-pack.c:report() ? Or shouldn't receive-pack let pkt-line.c perform the write calls?

-Lars

> PS Also, s/send/sent/ in the commit message.

Thanks :)