Re: [PATCH v5 14/15] convert: add filter.<driver>.process option

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 12, 2016, 17:13 UTC
Message-ID: <xmqqinv5ykoo.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <52049A60-6CEB-40E5-A013-409CFC20252F@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 10 quoted lines

>> If we do the success first and then error out halfway, we
>> still have to clean up, so I do not see how this impacts
>> implementation?
>
> That is true. The reasoning is that an error in between is somewhat
> less expected. Therefore additional work is OK.
>
> An error upfront is much more likely because it is also a mechanism
> for the filter to reject certain files. If the filter is configured
> as "required=false" then this reject would actually be OK.

Unless the reasoning is "an error in between is so rare that we are OK if the protocol misbehaves and the receiving end omits error handing", I am not so sure how "therefore additional work is OK" is a reasonable conclusion.