From: Junio C Hamano Date: Wed, 10 Aug 2016 18:42:33 GMT Subject: Re: [PATCH v5 05/15] pkt-line: add packet_write_gently_fmt() Message-ID: In-Reply-To: <2B2AC073-95AD-42E9-AD3A-23E8E13C66DE@gmail.com> Lars Schneider writes: >>> Similarly, I'd think this could share code with the non-gentle form >>> (which should be able to just call this and die() if returns an error). >>> Though sometimes the va_list transformation makes that awkward. >> >> Yes. > > Peff just posted that he tried the shared code idea but the result > ended up ugly. OK.