Re: [PATCH v5 02/15] pkt-line: call packet_trace() only if a packet is actually send

From: Jeff King <peff@peff.net>
Date: Aug 10, 2016, 14:33 UTC
Message-ID: <20160810143321.q7mjirgr5ynml5ff@sigill.intra.peff.net>
In-Reply-To: <9BF0767F-6B10-42D5-9A72-2710A753E26A@gmail.com>

On Wed, Aug 10, 2016 at 03:51:35PM +0200, Lars Schneider wrote:

> I guess my point is that I stumbled over the un-intutiive format_packet() behavior
> and I wanted to improve the situation in a way that others don't run into this
> trap. If you think that is no issue then it would be OK for me if we leave the
> current behavior as is.

I don't think the behavior as-is is a problem, and it would remain OK as long as no callers are added who format a packet but don't write it (or don't write it in a timely manner).

But most importantly, if you are going to refactor code, you can't regress the existing callers. So even if we did want to change how this worked, this patch is not acceptable as-is; it would need to fix up all of the callers of packet_buf_write().

-Peff