Re: [PATCH v5 02/15] pkt-line: call packet_trace() only if a packet is actually send

From: Jeff King <peff@peff.net>
Date: Aug 10, 2016, 13:13 UTC
Message-ID: <20160810131317.a4npld5hf2qk6wiq@sigill.intra.peff.net>
In-Reply-To: <20160810130411.12419-3-larsxschneider@gmail.com>

On Wed, Aug 10, 2016 at 03:03:58PM +0200, larsxschneider@gmail.com wrote:

Show 7 quoted lines

> From: Lars Schneider <larsxschneider@gmail.com>
> 
> The packet_trace() call is not ideal in format_packet() as we would print
> a trace when a packet is formatted and (potentially) when the packet is
> actually send. This was no problem up until now because format_packet()
> was only used by one function. Fix it by moving the trace call into the
> function that actually sends the packet.

It looks like there are two functions: packet_write() and packet_buf_write().

Your patch only touches one of them, and it looks like we would fail to trace many packets (e.g., see receive-pack.c:report(), which uses packet_buf_write() and then write()s out the result).

-Peff

PS Also, s/send/sent/ in the commit message.