Re: [PATCH v5 3/4] bloom: replace struct bloom_key * with struct bloom_keyvec

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 10, 2025, 16:17 UTC
Message-ID: <xmqqv7o06mw2.fsf@gitster.g>
In-Reply-To: <20250710084829.2171855-4-502024330056@smail.nju.edu.cn>

Lidong Yan <yldhome2d2@gmail.com> writes:

>  static void prepare_to_use_bloom_filter(struct rev_info *revs)
>  {
>  	struct pathspec_item *pi;
> +	struct bloom_keyvec *bloom_keyvec;

This new variable is no longer used, since the code to create a new keyvec is in a helper function and its return value is directly stored in the array of keyvecs.

>  	char *path_alloc = NULL;
>  	const char *path, *p;

And the "p" variable no longer is used, because the logic it used to create a new keyvec is moved elsewhere.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.