Re: [PATCH 2/2] bloom: enable multiple pathspec bloom keys
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 1, 2025, 15:43 UTC
- Message-ID
- <xmqqfrfflxw8.fsf@gitster.g>
- In-Reply-To
- <aGOhY2YuJZNG8ovj@szeder.dev>
SZEDER Gábor <szeder.dev@gmail.com> writes:
Show 11 quoted lines
> On Fri, Jun 27, 2025 at 06:50:22AM -0700, Junio C Hamano wrote: >> Totally outside the topic, but I wonder if we can further optimize >> by adding an early rejection using .nowildcard_len? Instead of >> allowing a wildcarded "dir/*" pathspec element from disabling the >> Bloom filter altogether, we could say "dir/ is not possibly altered, >> so there may be dir/A, dir/B, etc., in the directory, nothing that >> would match dir/* wildcard would have been modified", couldn't we? > > Indeed, that's what I demonstrated back in: > > https://public-inbox.org/git/20200529085038.26008-35-szeder.dev@gmail.com/
Heh, I am always impressed that some people seem to have infinitely long scrollback buffer ;-) It is curious why nobody else noticed and advocated for your patch back then.