From: Junio C Hamano Date: Thu, 10 Jul 2025 16:17:33 GMT Subject: Re: [PATCH v5 3/4] bloom: replace struct bloom_key * with struct bloom_keyvec Message-ID: In-Reply-To: <20250710084829.2171855-4-502024330056@smail.nju.edu.cn> Lidong Yan writes: > static void prepare_to_use_bloom_filter(struct rev_info *revs) > { > struct pathspec_item *pi; > + struct bloom_keyvec *bloom_keyvec; This new variable is no longer used, since the code to create a new keyvec is in a helper function and its return value is directly stored in the array of keyvecs. > char *path_alloc = NULL; > const char *path, *p; And the "p" variable no longer is used, because the logic it used to create a new keyvec is moved elsewhere.