Re: [PATCH v3 1/2] bloom: replace struct bloom_key * with struct bloom_keyvec

From: Lidong Yan <502024330056@smail.nju.edu.cn>
Date: Jul 3, 2025, 01:41 UTC
Message-ID: <B02F0A96-0D2F-41E8-A3CE-A840024092ED@smail.nju.edu.cn>
In-Reply-To: <xmqqy0t6curr.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> It is very dubious that murmur3_seeded_v2() is exposed (nobody would
> know it is for Bloom filter subsystem from that name); as far as I
> can tell, it is only needed for t/helper testing, and makes me
> wonder if we can come up with a better division between the
> production code and t/helper/ code around there.
> 
> Thanks.

Maybe we can do something like this:
    struct bloom_filter_settings settings;
    struct bloom_key key;
    uint32_t hash0;

    settings->num_hashes = 1;
    settings->hash_version = 2;
    fill_bloom_key(argv[2], strlen(argv[2]), &key, &setting);
    hash0 = key->hash[0];
    clear_bloom_key(&key);

    return hash0;

In t/helper, so that we don’t need to export murmur3_seeded_v2().