Re: [PATCH v6 5/5] bloom: optimize multiple pathspec items in revision

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 14, 2025, 17:01 UTC
Message-ID: <xmqqbjpmu2oz.fsf@gitster.g>
In-Reply-To: <30afce8c-c932-4c51-9a27-e63385608514@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 16 quoted lines

> On 7/12/2025 5:51 AM, Lidong Yan wrote:
>> To enable optimize multiple pathspec items in revision traversal,
>> return 0 if all pathspec item is literal in forbid_bloom_filters().
>> Add for loops to initialize and check each pathspec item's bloom_keyvec
>> when optimization is possible.
>
> The patch itself is good.
>
>> Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
>> Signed-off-by: Derrick Stolee <stolee@gmail.com>
>
> Here, I'll just point out that your sign-off should follow mine
> because you were the last to touch the patch. In this way, the
> sign-off gives a kind of timestamp to who made the most-recent
> changes (and that those changes have that person's sign-off,
> and may not have been vetted by previous signers).

Thanks for pointing it out. Also perhaps a single-liner attribution to clarify who did what, e.g.

	Signed-off-by: Derrick
	[ly: did this and that to derrick's code to adjust]
	Signed-off-by: Lidong

would be more helpful.