Re: [PATCH 2/2] bloom: enable multiple pathspec bloom keys

From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Jul 1, 2025, 08:50 UTC
Message-ID: <aGOhY2YuJZNG8ovj@szeder.dev>
In-Reply-To: <xmqqy0td8fa9.fsf@gitster.g>

On Fri, Jun 27, 2025 at 06:50:22AM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> Totally outside the topic, but I wonder if we can further optimize
> by adding an early rejection using .nowildcard_len?  Instead of
> allowing a wildcarded "dir/*" pathspec element from disabling the
> Bloom filter altogether, we could say "dir/ is not possibly altered,
> so there may be dir/A, dir/B, etc., in the directory, nothing that
> would match dir/* wildcard would have been modified", couldn't we?

Indeed, that's what I demonstrated back in:

  https://public-inbox.org/git/20200529085038.26008-35-szeder.dev@gmail.com/

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.