Re: [PATCH 2/2] bloom: enable multiple pathspec bloom keys

From: Lidong Yan <yldhome2d2@gmail.com>
Date: Jul 2, 2025, 07:14 UTC
Message-ID: <D5CB9B7A-C7B2-4F5A-B358-8F46A4E18CDB@gmail.com>
In-Reply-To: <xmqqo6u4kkg0.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 6 quoted lines

> 
> I do not know about icase; though.  Asking about "Dir/Path" and
> getting "Dir/ or Dir/Path cannot possibly be in the set of paths
> that were modified" from the changed-path Bloom filter would not
> help us optimize the tree comparison out, when we do not want to
> miss modifications for "dir/path".

Make sense, both PATHSPEC_EXCLUDE and PATHSPEC_ICASE shouldn’t be optimized by bloom filter.

I found that my [PATCH v3 2/2] contains two unaligned parameters. Should I reroll this patch and introduce the nowildcard_len change in a separate commit?

Show 9 quoted lines

> 
>> Here;s are all possible pathspec magic
>> #define PATHSPEC_FROMTOP (1<<0)
>> #define PATHSPEC_MAXDEPTH (1<<1)
>> #define PATHSPEC_LITERAL (1<<2)
>> #define PATHSPEC_GLOB (1<<3)
>> #define PATHSPEC_ICASE (1<<4)
>> #define PATHSPEC_EXCLUDE (1<<5)
>> #define PATHSPEC_ATTR (1<<6)