Re: [PATCH v6 0/5] bloom: enable bloom filter optimization for multiple pathspec elements in revision traversal

From: Lidong Yan <502024330056@smail.nju.edu.cn>
Date: Jul 15, 2025, 01:34 UTC
Message-ID: <B090DCBA-7306-4BA9-A5BA-DA81D1ABB29C@smail.nju.edu.cn>
In-Reply-To: <0969e176-b9c7-464d-8e97-cf5cd4a06347@gmail.com>

Derrick Stolee <stolee@gmail.com> wrote:

Show 15 quoted lines

> 
> On 7/12/2025 5:35 AM, Lidong Yan wrote:
> 
>> The difference from v5 is:
>>  - extract convert pathspec item to bloom_keyvec logic to
>>    a separate function, which simplifies the prepare_to_use_bloom_filter()
>>    function.
>>  - fix few bugs in v5.
> 
> Thanks for making these changes. Including your fixed patch 5, this
> version looks ready to me.
> 
> I wouldn't say "fix a few bugs" but instead "fix some compile-time
> linting complaints when using DEVELOPER=1" to be clear that the
> functionality hasn't changed but the code is cleaner.

I just learned that `make DEVELOPER=1` treats warnings as errors. Since this is just a cover letter issue, I feel it might not be worth rerolling the patch again.

Thanks, Lidong