Re: [PATCH v6 0/5] bloom: enable bloom filter optimization for multiple pathspec elements in revision traversal

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 14, 2025, 17:02 UTC
Message-ID: <xmqq7c0au2nq.fsf@gitster.g>
In-Reply-To: <0969e176-b9c7-464d-8e97-cf5cd4a06347@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 14 quoted lines

> On 7/12/2025 5:35 AM, Lidong Yan wrote:
>
>> The difference from v5 is:
>>   - extract convert pathspec item to bloom_keyvec logic to
>>     a separate function, which simplifies the prepare_to_use_bloom_filter()
>>     function.
>>   - fix few bugs in v5.
>
> Thanks for making these changes. Including your fixed patch 5, this
> version looks ready to me.
>
> I wouldn't say "fix a few bugs" but instead "fix some compile-time
> linting complaints when using DEVELOPER=1" to be clear that the
> functionality hasn't changed but the code is cleaner.

Thanks both, for polishing and reviewing.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.