Re: Re* [PATCH 8/9] fast-export: respect the possibly-overridden default branch name
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 12, 2020, 15:22 UTC
- Message-ID
- <xmqqpna42tt3.fsf@gitster.c.googlers.com>
- In-Reply-To
- <xmqqtuzg2twq.fsf@gitster.c.googlers.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> As I said already, I personally do not think that this needs to be a > preparatory patch to anonymize 'master' that cannot be configured to > something else into 'ref0'. This will become necessary when we make > the primary branch configurable, so I think it is easier to replace > the counterpart to your [PATCH 8/9] in the original series with it > in the v2 series.
Ah, I forgot to say, if you think it is easier to manage the main set of patches for the topic to eject as much preparatory changes as possible, I do not at all mind treating this as one of the preparatory step and queue it separately, making the main series depend on it. I just wanted to say that it is not necessary, even though it does not hurt.
> Regarding the update to the comment before this "special case", I > would suggest to explain "why" not just "what". > > Thanks.