Re: [PATCH v2 02/12] fmt-merge-msg: introduce a way to override the main branch name

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2020, 18:23 UTC
Message-ID: <xmqqeeqdv9e8.fsf@gitster.c.googlers.com>
In-Reply-To: <20200616130456.GF666057@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> I'm not sure if this check_refname_format() is valid, though. IIRC we've
> had issues where "ONELEVEL" was used to check a branch name, but misses
> some cases. The more full check done by strbuf_check_branch_ref()
> actually creates the full refname and checks that. It also catches stuff
> like refs/heads/HEAD.

Yup.

I actually am in favor of removing special casing of a single branch done by fmt-merge-msg and fast-export --anonymize, so this may not matter.

We still need a mechanism to allow users specify the default name to be given to the first branch "git init" creates and used by "git clone" as a fallback name when it cannot infer what the other side uses, though.