Re: Re* [PATCH 8/9] fast-export: respect the possibly-overridden default branch name

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 13, 2020, 05:00 UTC
Message-ID: <nycvar.QRO.7.76.6.2006130658330.56@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqpna42tt3.fsf@gitster.c.googlers.com>

Hi Junio,

On Fri, 12 Jun 2020, Junio C Hamano wrote:

Show 15 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
>
> > As I said already, I personally do not think that this needs to be a
> > preparatory patch to anonymize 'master' that cannot be configured to
> > something else into 'ref0'.  This will become necessary when we make
> > the primary branch configurable, so I think it is easier to replace
> > the counterpart to your [PATCH 8/9] in the original series with it
> > in the v2 series.
>
> Ah, I forgot to say, if you think it is easier to manage the main
> set of patches for the topic to eject as much preparatory changes as
> possible, I do not at all mind treating this as one of the
> preparatory step and queue it separately, making the main series
> depend on it.  I just wanted to say that it is not necessary, even
> though it does not hurt.

Due to the need to adjust t9351, I think it is clearer if it is a two-part change: one to introduce the "main branch -> ref0" change, and another one to respect `core.mainBranch`. Those are separate concerns in my mind.

I moved the first one to the beginning of the patch series so that you're still at liberty to take it early vs keeping it within the topic branch.

Thanks, Dscho