Re: [PATCH v2 11/12] submodule: use the correct default for the main branch name
- From
Jeff King <peff@peff.net>
- Date
- Jun 23, 2020, 21:14 UTC
- Message-ID
- <20200623211426.GA2072288@coredump.intra.peff.net>
- In-Reply-To
- <nycvar.QRO.7.76.6.2006232259320.54@tvgsbejvaqbjf.bet>
On Tue, Jun 23, 2020 at 11:03:57PM +0200, Johannes Schindelin wrote:
Show 18 quoted lines
> > [use HEAD instead of master] > This is the route that I am taking. > [...] > This is of course a bit worrisome, as there might actually be users out > there relying on the confusing behavior. > > However, I think it is okay to fix this: > > - The `git submodule update --remote` command does not strike me as > awfully common. In fact, I had never heard of it before I worked on this > here patch. > > - Current Git's behavior when running this command is outright confusing, > unless the remote repository's current branch _is_ `master` (in which > case the proposed behavior matches the old behavior). > > - It is actually easily fixed by setting `submodule.<name>.branch` to > `master` _iff_ users want to reinstate the old behavior.
Thanks, I agree that this is the best way forward, and that the current confusing behavior is as likely to be doing the wrong thing as the right (when it even differs).
-Peff